docs: update theme 1.8 #1081
Merged
docs: update theme 1.8 #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
24 tasks
|
God bless! |
Lorak-mmk
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I've successfully built the documentation. Dark theme looks awesome - code blocks have much better syntax highlighting than on light theme.
Is it possible to make the docs site respect browser preferences regarding theme? I have it set to "Dark" in firefox preferences, but it still opens light theme by default:
If not: is the default configurable somewhere? For Rust Driver docs can we change it to dark for better code block readability?
|
We'll work on making the docs site respect the system preferences in scylladb/sphinx-scylladb-theme#1231 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue scylladb/sphinx-scylladb-theme#1229
ScyllaDB Sphinx Theme 1.8 is out 🥳!
Here's a summary of changes:
poetry.lockfile to ensure consistent dependencies in your CI/CD pipeline.You can read more about all the notable changes here.
How to test this PR
Clone this PR.
Enter the docs folder, and run:
Open http://localhost:5500 in your browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be
1.8.x: